refactor: eliminate uncors wrapper, wire server directly through cli - #97

…ncors wrapper

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…Targets

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- RunUncors and runNonIneractive now accept a context.Context so callers
  (including tests) can control server lifetime via cancellation
- Shutdown goroutine handles both OS signals and ctx.Done, ensuring the
  server stops cleanly in either case
- Removed duplicate mappingsToTarget from run_non_ineractive.go; now
  uses container.Targets(cfg) consistently
- bootProxy rewrites to serialize the config to YAML, call cli.RunUncors
  in a goroutine with t.Context(), and poll mapped ports for readiness

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- RunUncors defaults to interactive mode (defaultConfig sets Interactive:true);
  bootProxy must override with --interactive=false so the proxy starts its
  TCP listeners instead of launching the TUI
- Fix gofmt alignment in const block
- Replace 0o644 magic number with named constant configFilePerm
- Replace net.DialTimeout with (*net.Dialer).DialContext (noctx linter)
- Rename loop variable m -> mapping (varnamelen linter)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

yaml.Marshal serializes zero-value CacheConfig fields
(expiration-time: 0s, max-size: 0, methods: []), which override
defaultConfig() when the YAML is reloaded, causing integration
test boot to fail with CacheConfig validation errors.

omitempty on individual fields ensures zero values are omitted from
the serialized YAML, preserving the defaults on reload.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Adds tests for RunUncors (load error, startup/shutdown, port-in-use, config
reload success and error paths) and GenerateCerts, covering the new internal/cli
package. Extends di public_api_test with TestContainerTargets (HTTP, HTTPS,
port grouping). Adds main_test.go covering setupLogging and main() code paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Server.Shutdown could race with Server.Start (called via Restart) because
both access s.listeners without synchronisation. Introduce a sync.RWMutex:
Start holds the write lock while replacing the slice, Shutdown and Close
snapshot the slice under the read lock before iterating.

Also add internal/infra/loggings_test.go so that the SetupLogging function
(moved here from main.go in the previous refactor) is covered at the package
level rather than only through main_test.go cross-package calls.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- generate_certs.go: GenerateCerts function for CLI cert generation
- run_uncors.go: RunUncors entry point that routes to interactive/non-interactive
- run_ineractive.go: runIneractive for TUI mode (BubbleTea-based)
- run_non_ineractive.go: runNonIneractive for headless mode with config watching

Also:
- Remove --debug CLI flag; logging now controlled solely via UNCORS_LOGGING env var
- Rename parameters for consistency: uncorsConfig→cfg, configPath→cfgPath
- Add context.Context to runIneractive for proper lifecycle management

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…orbidigo/nlreturn/wsl_v5)

- run_uncors.go: replace forbidden println with fmt.Fprintln(os.Stdout, ...)
  and add blank line before return nil after version print
- config.go: add blank line before if printVersion block (wsl_v5)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- RunUncors: add tests for --version (prints version, returns nil) and
  --help (returns nil via pflag.ErrHelp)
- GenerateCerts: add test for --help flag returning nil
- LoadConfiguration: add test confirming --version returns ErrVersionRequested

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…process

Extract os.Exit into a package-level var so tests can replace it.
Add TestHandleError_ExitsOnError and TestHandleError_NoopOnNil to
cover the previously uncovered error branch, restoring coverage above 80%.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>